Sync extension bridge settings with cloud #7506
Conversation
dosubot
bot
added
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
|
|
||
| const remoteControlEnabled = isCloudAgent | ||
| ? true | ||
| : (CloudService.instance.getUserSettings()?.settings?.extensionBridgeEnabled ?? false) |
There was a problem hiding this comment.
Is this intentional? The error handling here only logs the error but doesn't provide any fallback value for remoteControlEnabled. If getUserSettings() returns null/undefined, the remote control state could be out of sync.
Consider ensuring the fallback value is always applied.
|
|
||
| const remoteControlEnabled = isCloudAgent | ||
| ? true | ||
| : (CloudService.instance.getUserSettings()?.settings?.extensionBridgeEnabled ?? false) |
There was a problem hiding this comment.
This logic for determining remoteControlEnabled is duplicated from lines 144-146. Could we extract this into a helper function to avoid duplication?
For example:
function getRemoteControlEnabled(isCloudAgent: boolean): boolean {
return isCloudAgent ? true : (CloudService.instance.getUserSettings()?.settings?.extensionBridgeEnabled ?? false);
}| let remoteControlEnabled: boolean = false | ||
|
|
||
| try { | ||
| const cloudSettings = CloudService.instance.getUserSettings() |
There was a problem hiding this comment.
Missing null check - what happens if CloudService is not initialized yet? The code uses optional chaining but doesn't verify that CloudService.instance exists.
Consider adding a hasInstance() check before accessing the instance.
| extensionBridgeEnabled: message.bool ?? false, | ||
| }) | ||
| } catch (error) { | ||
| provider.log(`Failed to update cloud settings for remote control: ${error}`) |
There was a problem hiding this comment.
The error is only logged but doesn't provide user feedback. Should we show an error message to the user when cloud settings fail to update?
Consider adding a user-facing error notification.
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
hannesrudolph
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
github-project-automation
bot
moved this from PR [Changes Requested]
to Done
in Roo Code Roadmap
Important
Sync
remoteControlEnabledsetting with cloud, making cloud the source of truth, and improve error handling for cloud interactions.remoteControlEnabledsetting inClineProvider.tsnow fetched from cloud settings usingCloudService.instance.getUserSettings().webviewMessageHandler.ts, updates toremoteControlEnablednow update cloud settings viaCloudService.instance.updateUserSettings().extension.tsupdatesExtensionBridgeServicewithremoteControlEnabledfrom cloud settings.ClineProvider.tsandextension.ts.remoteControlEnabledinClineProvider.ts.This description was created by
for dace718. You can customize this summary. It will automatically update as commits are pushed.